Conversation
|
I am sorry, I could not find test cases. So, I didn't start anything new for the same |
|
Hi mate. I believe you want to add the addition of a HTTP header "User-Agent" to the request options. You can leave the AGENT stuff alone (that is for something else, reusing TLS connections but issue #264 is different) |
|
So add standard http header "User-Agent" with value "authorization-at-edge" or so to the |
|
I'm sorry. I misunderstood the issue. Thanks for pointing in the right direction. I updated the PR. |
|
Cheers mate and no worries! Easy to make mistakes Having looked around a bit, I see the usual format for User-Agent is I like adding the Auth@Edge version in there, so that we e.g. get If you're up to adding that, go for it. If that's a bit too much I can understand too let me know. Question: did you test it like this? Does this indeed work to not run into the WAF rule? |
ottokruse
left a comment
There was a problem hiding this comment.
Can you run prettier? (code formatting: npx prettier -w .)
| ); | ||
|
|
||
| const headers: { "Content-Type": string; Authorization?: string } = { | ||
| const headers: { "Content-Type": string; Authorization?: string; "User-Agent":string } = { |
There was a problem hiding this comment.
Let's just change this type to OutgoingHttpHeaders -- bit annoying to spell all keys we use out like this.
#264
if user agent is missing, it provides default agent with default max cached session 50.